Skip to content

Update http-foundation.rst #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update http-foundation.rst #5479

wants to merge 1 commit into from

Conversation

jezemery
Copy link

@jezemery jezemery commented Jul 3, 2015

Just fixed a small grammatical error

Update http-foundation.rst
4679fbe 
Just fixed a small grammatical error
@javiereguiluz
Copy link
Member

@jezemery thanks for this fix, congrats on your first contribution and welcome to the big family of Symfony Contributors!

Once this change is merged, if you have a SensioLabs Connect profile with the same email as your GitHub account, you'll receive the cool Symfony Doc Contributor badge.

@xabbuh
Copy link
Member

xabbuh commented Jul 4, 2015

👍 nice one @jezemery

@javiereguiluz Was that a +1 from you? :)

@jezemery
Copy link
Author

jezemery commented Jul 4, 2015

Thanks guys. I didn't realise there were contribution docs online before I did this so I think the format is off. Sorry!

@wouterj
Copy link
Member

wouterj commented Jul 23, 2015

No worries, Jeremy. This PR is very easy to merge and probably didn't take long to create, and that's the most important bit of contributing. I've now patched it into the 2.3 branch (which is the lowest version that we still maintain) and will merge it up to the master version from there (this is why the PR is shown as closed instead of merged). Thanks!

wouterj added a commit that referenced this pull request Jul 23, 2015
@wouterj
minor #5479 Update http-foundation.rst (jezemery)
0c648d2 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5479).

Discussion
----------

Update http-foundation.rst

Just fixed a small grammatical error

Commits
-------

50f1f20 Update http-foundation.rst
@wouterj wouterj closed this Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jezemery @javiereguiluz @xabbuh @wouterj