Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed headline #5490

Closed
wants to merge 1 commit into from
Closed

changed headline #5490

wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz reviewed Jul 6, 2015
View reviewed changes
create_framework/index.rst
@@ -1,4 +1,4 @@
Create your PHP Framework
Create your own PHP Framework
=========================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: in Symfony docs, the second line of the headline must be of the same length of the first line.

@OskarStark
Copy link
Contributor Author

fixxed @javiereguiluz

@OskarStark
Copy link
Contributor Author

arrgh :)

@OskarStark
Copy link
Contributor Author

now.... grml :)

@xabbuh
Copy link
Member

xabbuh commented Jul 6, 2015

👍 looks good

@wouterj
Copy link
Member

wouterj commented Jul 23, 2015

Thank you Oskar.

wouterj added a commit that referenced this pull request Jul 23, 2015
@wouterj
minor #5490 changed headline (OskarStark)
7bfac23 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5490).

Discussion
----------

changed headline

Commits
-------

aed00de changed headline
@wouterj wouterj closed this Jul 23, 2015
@OskarStark OskarStark deleted the patch-3 branch June 17, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @xabbuh @wouterj @javiereguiluz