Edit tests in unit-testing.rst to fix error #5500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In symfony-docs/create_framework/unit-testing.rst, in the
"FrameworkTest" class, make following changes to
protected method named "getFrameworkForException" and to test
method named "testControllerResponse":
(i) add mock RequestContext, and
(ii) add to mock URLMatcherInterface the expectation that its
"getContext" method will be called and will return the mock
RequestContext.
Reason: Prior to these changes, running phpunit while following the
tutorial causes php error with message:
"Fatal error: Call to a member function fromRequest() on null in
[path/to/]example.com/src/Simplex/Framework.php on line 24"
The line 24 referred to in the foregoing error message is the first
line of the Framework class's handle method:
"$this->matcher->getContext()->fromRequest($request);"
|
Thanks for submitting this fix! Unfortuantely, 2 days before you submitted this PR, someone already submitted a fix: #5488 As that fixed is now merged, I'm going to close this one. Thanks again! 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In symfony-docs/create_framework/unit-testing.rst, in the
tutorial's "FrameworkTest" class, make following changes to
protected method named "getFrameworkForException" and to test
method named "testControllerResponse":
(i) add mock RequestContext, and
(ii) add to mock URLMatcherInterface the expectation that its
"getContext" method will be called and will return the mock
RequestContext.
Reason: Prior to these changes, running phpunit while following the
unit-testing.rst tutorial causes php error with message:
"Fatal error: Call to a member function fromRequest() on null in
[path/to/]example.com/src/Simplex/Framework.php on line 24"
The line 24 referred to in the foregoing error message is the first
line of the "handle" method of the tutorial's "Framework" class:
"$this->matcher->getContext()->fromRequest($request);"