Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved comment to the right place #5646

Closed
wants to merge 1 commit into from

Conversation

mickaelandrieu
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to >= 2.3 afaik
Fixed tickets none

I think this move is required because we can think at this moment that the function link() send the click that is wrong (link() function create a Link object from the selector or throw an exception).

@OskarStark
Copy link
Contributor

👍

@wouterj
Copy link
Member

wouterj commented Aug 21, 2015

👍

@mickaelandrieu
Copy link
Contributor Author

I love the "Finished" tag \o/ thank you @wouterj

@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2015

Thank you Mickaël.

xabbuh added a commit that referenced this pull request Aug 22, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5646).

Discussion
----------

Moved comment to the right place

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | >= 2.3 afaik
| Fixed tickets | none

I think this move is required because we can think at this moment that the function ``link()`` send the click that is wrong (link() function create a Link object from the selector or throw an exception).

Commits
-------

9353afc Moved comment to the right place
@xabbuh xabbuh closed this Aug 22, 2015
@mickaelandrieu mickaelandrieu deleted the patch-3 branch August 22, 2015 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants