Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http_cache.rst #5673

Closed
wants to merge 1 commit into from
Closed

Update http_cache.rst #5673

wants to merge 1 commit into from

Conversation

szyszka90
Copy link
Contributor

Forgotten new Response instance in example from Validation with the Last-Modified Header section.

@szyszka90
Update http_cache.rst
ba165ee 
Forgotten new Response instance in example from Validation with the Last-Modified Header  section.
@javiereguiluz
Copy link
Member

👍 since we're displaying the entire example code, I think this is definitely needed.

@xabbuh
Copy link
Member

xabbuh commented Sep 5, 2015

👍 I completely agree. Nice catch @szyszka90!

@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

Thanks @szyszka90 for testing & fixing the code examples in the docs!

wouterj added a commit that referenced this pull request Sep 5, 2015
@wouterj
bug #5673 Update http_cache.rst (szyszka90)
5834340 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5673).

Discussion
----------

Update http_cache.rst

Forgotten new Response instance in example from ```Validation with the Last-Modified Header``` section.

Commits
-------

aa1750b Update http_cache.rst
@wouterj wouterj closed this Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szyszka90 @javiereguiluz @xabbuh @wouterj