Wrap all strings containing @ in quotes in Yaml #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really care about this, but if we merge it, we should single quotes for quoting (and I think we should do that everywhere else too as it is much easier to use because you do not have to care about escape sequences). |
weaverryan
added a commit
that referenced
this pull request
Nov 30, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Wrap all strings containing @ in quotes in Yaml | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5910 These where all strings I found with some simple grepping, I think we're pretty safe after merging this. Commits ------- 40243a1 Wrap all strings containing @ in quotes in Yaml
|
Thanks! @xabbuh I agree with you - that's also why we use single quotes in PHP. Can you make a PR or at least open an issue to update double quotes to singles? |
|
@weaverryan I opened #5935 to keep track of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These where all strings I found with some simple grepping, I think we're pretty safe after merging this.