Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention routing from the database #6021

Merged
merged 1 commit into from
Feb 16, 2016
Merged

mention routing from the database #6021

merged 1 commit into from
Feb 16, 2016

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Dec 16, 2015

Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets #2186, relates to #5709

if we merge #6020, we might want to put this as subsection of the extending_routing section

When all routes are known during deploy time and the number is not too
high, using a :doc:`custom route loader <custom_route_loader>` is the
preferred way to add more routes. When working with just one type of
objects, a slug parameter on the object and the `@ParamConverter`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParamConverter should be enclosed with double backticks.

Copy link
Contributor Author

@dbu dbu Dec 16, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dupuchba
Copy link

nice :-)

@dbu dbu mentioned this pull request Dec 16, 2015
5 tasks
@@ -12,3 +12,4 @@ Routing
custom_route_loader
redirect_trailing_slash
extra_information
routing_from_database
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add a reference to /cookbook/routing/map.rst.inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dbu
Copy link
Contributor Author

dbu commented Jan 4, 2016

i updated to all the feedback. anything left to do?

@dbu
Copy link
Contributor Author

dbu commented Feb 16, 2016

ping @weaverryan is there a reason to not merge this? happy to correct things if you can tell me what i should change.

@weaverryan weaverryan merged commit c458431 into symfony:2.3 Feb 16, 2016
weaverryan added a commit that referenced this pull request Feb 16, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

mention routing from the database

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | #2186, relates to #5709

if we merge #6020, we might want to put this as subsection of the extending_routing section

Commits
-------

c458431 mention routing from the database
@weaverryan
Copy link
Member

@dbu no reason at all - sorry for the delay :)

@dbu dbu deleted the routing-from-database branch October 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants