Add browserkit component documentation #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The component only provides an abstract client and does not provide any backend | ||
| ready to use for the HTTP layer. | ||
|
|
||
| To create your own client you must extend the abstract client class and |
There was a problem hiding this comment.
"[...] own client, you must [...]"
There was a problem hiding this comment.
Maybe "client class" -> "Client class"
|
I've left lot's of minor comments, but 👍 for merging this one without adding more content. |
|
@wouterj thanks for the detailed review. I think I've done all the suggested changes. |
javiereguiluz
force-pushed
the
pr/4312
branch
from
e930e79
to
c9093a8
Compare
|
|
||
| * :doc:`Install it via Composer </components/using_components>` | ||
| (``symfony/browser-kit`` on `Packagist`_); | ||
| * Use the official Git repository (https://github.com/symfony/BrowserKit). |
There was a problem hiding this comment.
after the normalisation done recently the real URL is https://github.com/symfony/browser-kit
|
+1 Thanks for making the needed improvements. |
|
Can someone please review & vote this PR? /cc @weaverryan @xabbuh |
xabbuh
added a commit
that referenced
this pull request
Feb 9, 2016
…ninja, robert Parker, javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Add browserkit component documentation | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | - This PR tries to finish the fantastic work made by @yamiko-ninja in #4312. Please review it so I can improve/finish it and we can merge it before year's end. Thanks! Commits ------- 3f0858f Fixed a syntax issue c9093a8 Implemented changes suggested by Wouter e7056a8 Fixed a reference 5aec7c4 Minor fixes fd35c93 Fixed a syntax issue 883c062 Finished the first version of the BrowserKit doc 03ea5a5 fix title underline a1df783 spelling and formating ea3fd71 Adding documentation for cookies 6b6e23a added docs on histroy a3d158e added form submissions and moved creating a client to top 74cfecd more outlines, fixed link, added more about creating a client dda78ba added a link snippit 94bb3bf fixed spelling 6997c4f make a basic request b3d9eb3 added links to index and map files f0f8a50 added links with info about clients and packagist link 1e5ca13 added in sections that I apln to fill out 9c007e9 syntax fix 645d50d fixed a few mistakes 93d7258 added introduction
|
Thank you @yamiko-ninja and @javiereguiluz for your great work. I have merged this PR into the |
xabbuh
added a commit
that referenced
this pull request
Feb 9, 2016
* 2.3: (24 commits) removed duplicate lines Updated "Learn more from the Cookbook" section [#6072] some tweaks Fixed a syntax issue Implemented changes suggested by Wouter Fixed a reference Minor fixes Fixed a syntax issue Finished the first version of the BrowserKit doc fix title underline spelling and formating Adding documentation for cookies added docs on histroy added form submissions and moved creating a client to top more outlines, fixed link, added more about creating a client added a link snippit fixed spelling make a basic request added links to index and map files added links with info about clients and packagist link ... Conflicts: components/index.rst components/map.rst.inc
xabbuh
added a commit
that referenced
this pull request
Feb 9, 2016
* 2.7: (26 commits) removed duplicate lines Updated "Learn more from the Cookbook" section [#6072] some tweaks [Cookbook][Console] change API doc class name Improvement to the apache/mod_php configuration example Fixed a syntax issue Implemented changes suggested by Wouter Fixed a reference Minor fixes Fixed a syntax issue Finished the first version of the BrowserKit doc fix title underline spelling and formating Adding documentation for cookies added docs on histroy added form submissions and moved creating a client to top more outlines, fixed link, added more about creating a client added a link snippit fixed spelling make a basic request ...
xabbuh
added a commit
that referenced
this pull request
Feb 9, 2016
* 2.8: (26 commits) removed duplicate lines Updated "Learn more from the Cookbook" section [#6072] some tweaks [Cookbook][Console] change API doc class name Improvement to the apache/mod_php configuration example Fixed a syntax issue Implemented changes suggested by Wouter Fixed a reference Minor fixes Fixed a syntax issue Finished the first version of the BrowserKit doc fix title underline spelling and formating Adding documentation for cookies added docs on histroy added form submissions and moved creating a client to top more outlines, fixed link, added more about creating a client added a link snippit fixed spelling make a basic request ...
xabbuh
added a commit
that referenced
this pull request
Feb 9, 2016
* 3.0: (27 commits) Removed all 2.x versionadded directives removed duplicate lines Updated "Learn more from the Cookbook" section [#6072] some tweaks [Cookbook][Console] change API doc class name Improvement to the apache/mod_php configuration example Fixed a syntax issue Implemented changes suggested by Wouter Fixed a reference Minor fixes Fixed a syntax issue Finished the first version of the BrowserKit doc fix title underline spelling and formating Adding documentation for cookies added docs on histroy added form submissions and moved creating a client to top more outlines, fixed link, added more about creating a client added a link snippit fixed spelling ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to finish the fantastic work made by @yamiko-ninja in #4312. Please review it so I can improve/finish it and we can merge it before year's end. Thanks!