To use annotations, files must be removed #6251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm proposing this change after spending an hour trying to work out why my Repository class wasn't loading. Thanks to `ysor123` on IRC, we diagnosed the problem was the XML mapping files generated when reverse engineering my database, which I hadn't deleted. This is obliquely referred to at http://symfony.com/doc/current/book/doctrine.html#add-mapping-information: > A bundle can accept only one metadata definition format. For example, it's not possible to mix YAML metadata definitions with annotated PHP entity class definitions. It'd be great to clarify this for future readers.
| If you want to use annotations, you must remove the XML (or YAML) files | ||
| after running these two commands. It is `not possible to mix XML/YAML metadata | ||
| definitions with annotated PHP entity class definitions | ||
| <http://symfony.com/doc/current/book/doctrine.html#add-mapping-information>`_. |
There was a problem hiding this comment.
The addition is nice, but we should use the ref role to link to that section like this (I would also reword this a bit):
If you want to use annotations, you must remove the XML (or YAML) files
after running these two commands. This is necessary as
:ref:`it is not possible to mix mapping configuration formats <book-doctrine-adding-mapping>`.
|
this should be merged to prior branches, too what do you think @xabbuh ? |
|
Yes, we will do that when merging the PR. |
|
👍 |
|
Thanks @xabbuh I've updated the PR in line with your comment. |
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Feb 21, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6251). Discussion ---------- To use annotations, files must be removed | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | Tested on 3.0 | Fixed tickets | N/A I'm proposing this change after spending an hour trying to work out why my Repository class wasn't loading. Thanks to `ysor123` on IRC, we diagnosed the problem was the XML mapping files generated when reverse engineering my database, which I hadn't deleted. This is obliquely referred to at http://symfony.com/doc/current/book/doctrine.html#add-mapping-information: > A bundle can accept only one metadata definition format. For example, it's not possible to mix YAML metadata definitions with annotated PHP entity class definitions. It'd be great to clarify this for future readers. Commits ------- 06de6c0 Updated per xabbuh's comment 6a526bf To use annotations, files must be removed
weaverryan
added a commit
that referenced
this pull request
Feb 21, 2016
|
Thanks Peter! I merged this into the 2.3 branch and changed the block also to be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing this change after spending an hour trying to work out why my Repository class wasn't loading.
Thanks to
ysor123on IRC, we diagnosed the problem was the XML mapping files generated when reverse engineering my database, which I hadn't deleted.This is obliquely referred to at http://symfony.com/doc/current/book/doctrine.html#add-mapping-information:
It'd be great to clarify this for future readers.