Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Bundles]fix yaml syntax #6269

Merged
merged 1 commit into from
Feb 15, 2016
Merged

[Cookbook][Bundles]fix yaml syntax #6269

merged 1 commit into from
Feb 15, 2016

Conversation

mhor
Copy link
Contributor

@mhor mhor commented Feb 13, 2016

Q A
Doc fix? yes
New docs? no
Applies to all

@mhor mhor changed the title fix yaml syntax [Cookbook][Bundles]fix yaml syntax Feb 13, 2016
@wouterj
Copy link
Member

wouterj commented Feb 13, 2016

👍

1 similar comment
@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Feb 14, 2016

Technically, the YAML syntax was valid before, but we need this change so that Sphinx renders the code block successfully. However, the code block will still be rendered without any syntax highlighting as the code block type is text. So I think we should either abstain from making this change or also change the code block type to yaml.

@mhor
Copy link
Contributor Author

mhor commented Feb 14, 2016

@xabbuh, I changed block type to yaml. This yaml is technically invalid see https://github.com/symfony/symfony-standard/issues/426

@xabbuh
Copy link
Member

xabbuh commented Feb 14, 2016

👍

Regarding the syntax, I think I will have to read the spec again and maybe we need to fix the Yaml component in regard of how to treat indicator characters. Thanks for pointing that out @mhor.

@xabbuh
Copy link
Member

xabbuh commented Feb 15, 2016

Thinking about this again, I think we should change the type of the code block back to text as the output that you see in your terminal won't be coloured either.

| Q                | A
| --------------- | ----
| Doc fix?      | yes
| New docs? | no
| Applies to   | all
@mhor
Copy link
Contributor Author

mhor commented Feb 15, 2016

I agree with you @xabbuh. I revert modification of code-block

@xabbuh
Copy link
Member

xabbuh commented Feb 15, 2016

Thank you @mhor.

@xabbuh xabbuh merged commit d25a312 into symfony:2.3 Feb 15, 2016
xabbuh added a commit that referenced this pull request Feb 15, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Bundles]fix yaml syntax

| Q                | A
| --------------- | ----
| Doc fix?      | yes
| New docs? | no
| Applies to   | all

Commits
-------

d25a312 fix yaml syntax
@mhor mhor deleted the patch-1 branch February 15, 2016 21:45
fabpot added a commit to symfony/symfony that referenced this pull request Feb 18, 2016
…ers (xabbuh)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[Yaml] deprecate starting plain scalars with % characters

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-docs#6269, symfony/symfony-standard#426
| License       | MIT
| Doc PR        |

Commits
-------

e883a4c deprecate starting plain scalars with % characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants