Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of backtick inside double back-quotes #6371

Merged
merged 1 commit into from Mar 15, 2016
Merged

Fix escaping of backtick inside double back-quotes #6371

merged 1 commit into from Mar 15, 2016

Conversation

guilliamxavier
Copy link
Contributor

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets

This PR removes the backslash before the backtick inside a double-back-quoted inline code block, because there it is interpreted literally (and displayed too) instead of as an escaping character.

@xabbuh
Copy link
Member

xabbuh commented Mar 15, 2016

Great catch! Thank you for this perfect pull request @guilliamxavier!

@xabbuh xabbuh merged commit 1c297f9 into symfony:2.3 Mar 15, 2016
xabbuh added a commit that referenced this pull request Mar 15, 2016
…iamxavier)

This PR was merged into the 2.3 branch.

Discussion
----------

Fix escaping of backtick inside double back-quotes

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets |

This PR removes the backslash before the backtick inside a double-back-quoted inline code block, because there it is interpreted literally (and displayed too) instead of as an escaping character.

Commits
-------

1c297f9 Fix escaping of backtick inside double back-quotes
@guilliamxavier guilliamxavier deleted the patch-1 branch March 19, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants