Avoid confusion #6472
Closed
Avoid confusion #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all. Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample.
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Apr 26, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6472). Discussion ---------- Avoid confusion To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all. Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample. Commits ------- 6818b8e Avoid confusion
weaverryan
added a commit
that referenced
this pull request
Apr 26, 2016
|
Wow, I <3 it - it seems much simpler now. Thanks Gerry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all.
Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample.