Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated use of 'datetime' for Type #6603

Closed
wants to merge 1 commit into from
Closed

Conversation

dsmink
Copy link
Contributor

@dsmink dsmink commented May 23, 2016

'datetime' --> \Symfony\Component\Form\Extension\Core\Type\DateTimeType::class

'datetime' --> \Symfony\Component\Form\Extension\Core\Type\DateTimeType::class
@javiereguiluz
Copy link
Member

Instead of this:

\Symfony\Component\Form\Extension\Core\Type\DateTimeType::class

What about using:

'Symfony\Component\Form\Extension\Core\Type\DateTimeType'

or:

use Symfony\Component\Form\Extension\Core\Type\DateTimeType;

// ...

DateTimeType::class

@dsmink
Copy link
Contributor Author

dsmink commented May 23, 2016

Javier,

I prefer the latter, but that is debatable. The main thing is that The
example is incorrect.

Kind regards,

Dennis Smink
Op 23 mei 2016 3:39 p.m. schreef "Javier Eguiluz" <notifications@github.com

:

Instead of this:

\Symfony\Component\Form\Extension\Core\Type\DateTimeType::class

What about using:

'Symfony\Component\Form\Extension\Core\Type\DateTimeType'

or:

use Symfony\Component\Form\Extension\Core\Type\DateTimeType;// ...DateTimeType::class


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6603 (comment)

@xabbuh
Copy link
Member

xabbuh commented May 23, 2016

If I am not mistaken, we always have use statements where we did the change.

@javiereguiluz
Copy link
Member

We can close this in favor of the newer #6608.

@xabbuh
Copy link
Member

xabbuh commented May 24, 2016

You are right. Thanks for creating this PR @dsmink. I am closing here in favour of your other PR which we'll merge soon.

@xabbuh xabbuh closed this May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants