Process: callbacks now allowed when output disabled #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``setIdleTimeout``. | ||
|
|
||
| However, it is possible to pass a callback to the ``start``, ``run`` or ``mustRun`` | ||
| methods to handle process output in a streaming fashion. |
There was a problem hiding this comment.
Can you add a little versionadded block below this?
.. versionadded:: 3.1
The ability to pass a callback to these methods when output is disabled was added in Symfony 3.1.Thanks!
|
This looks great, other than we just need one small addition that I commented on. Status: Needs Work |
This is a recent change in 3.1 added by @romainneutron Callbacks are allowed even if output is disabled
|
Updated PR |
|
👍 A little note: The versionadded directive should be indented with 4 spaces, so it'll be part of the Status: Reviewed |
|
👍 |
xabbuh
added a commit
that referenced
this pull request
Jun 20, 2016
…indra) This PR was merged into the 3.1 branch. Discussion ---------- Process: callbacks now allowed when output disabled This is a recent change in 3.1 added by @romainneutron Callbacks are allowed even if output is disabled Related issue: symfony/symfony#17427 Commits ------- 687b915 Process: callbacks now allowed when output disabled
xabbuh
added a commit
that referenced
this pull request
Jun 20, 2016
|
Thank you @avindra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recent change in 3.1 added by @romainneutron
Callbacks are allowed even if output is disabled
Related issue: symfony/symfony#17427