Hard values for the driver option #6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to update the other config formats too. Status: Needs work |
|
Do you have any examples? I can add them while at it |
|
@iltar I mean the XML and PHP code blocks right below the YAML code blocks that you changed. |
linaori
force-pushed
the
fix/connection-driver-parameter
branch
from
6b17cdf
to
e26c32f
Compare
|
It was early and I was lacking coffee 😢 I've updated the xml/php examples underneath the yml variants. |
|
:) 👍 Status: Reviewed |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @iltar. |
xabbuh
added a commit
that referenced
this pull request
Jun 30, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Hard values for the driver option Fixes symfony/symfony#19196. As the drivers are not different per environment, but rather always the same, it shouldn't be a parameter. Commits ------- e26c32f Hard values for the driver option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes symfony/symfony#19196.
As the drivers are not different per environment, but rather always the same, it shouldn't be a parameter.