Removed empty Notes on previous versions
#6702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: reviewed Let's merge this into 2.8: We don't document 2.6 version changes in the 2.8 docs (we only document changes in versions that didn't reach end of life when the stable version was released). |
|
@wouterj oh, ignore my previous comment then :) Sorry ! and thanks for review |
|
Thanks Mickaël! |
wouterj
added a commit
that referenced
this pull request
Jul 5, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #6702). Discussion ---------- Removed empty `Notes on previous versions` On ``OptionsResolver`` component documentation, we have a ``Notes on previous versions`` section after Symfony 2.6. Since Symfony 2.8 docs, this section is empty, so I suggest to remove it for version 3.x and probably re-add it in 2.8. > This pull request should be applied in 3.0, 3.1, 3.2 **and 2.8** cf @wouterj comment Commits ------- 892fcce Removed empty `Notes on previous versions`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
OptionsResolvercomponent documentation, we have aNotes on previous versionssection after Symfony 2.6.Since Symfony 2.8 docs, this section is empty, so I suggest to remove it for version 3.x and probably re-add it in 2.8.