Updated the condition to display console name #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed @mickaelandrieu I wasn't aware of this change and I like it! Thanks for your PR. |
|
Great catch! Thanks Mickaël. |
wouterj
added a commit
that referenced
this pull request
Jul 8, 2016
…ndrieu) This PR was merged into the 3.1 branch. Discussion ---------- Updated the condition to display console name Before `3.1` we need both console name and version in order to display the console name instead of `console tool`, now we only need to setup the name. See symfony/console@56eb96d Commits ------- 325ccb7 Updated the condition to display console name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
3.1we need both console name and version in order to display the console name instead ofconsole tool, now we only need to setup the name.See symfony/console@56eb96d