Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the file() controller helper #6737

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This rewords #6732 to document the new feature with less words and more code.

return $this->file($file, 'custom_name.pdf');

// display the file contents in the browser instead of downloading it
$this->file('invoice_3241.pdf', 'my_invoice.pdf', ResponseHeaderBag::DISPOSITION_INLINE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@xabbuh
Copy link
Member

xabbuh commented Jul 9, 2016

👍

Status: Reviewed

@wouterj
Copy link
Member

wouterj commented Jul 9, 2016

👍 Thanks!

@wouterj wouterj closed this in b0b774a Jul 9, 2016
wouterj added a commit that referenced this pull request Jul 9, 2016
@javiereguiluz javiereguiluz deleted the reword_6732 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants