Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Ambiguous block prefixes render incorrectly #6744

Merged
merged 1 commit into from
Jul 10, 2016

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 10, 2016

Finishes #6646

@weaverryan
Copy link
Member

👍

@weaverryan weaverryan merged commit b44620d into 2.8 Jul 10, 2016
weaverryan added a commit that referenced this pull request Jul 10, 2016
…ly-nr1)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Ambiguous block prefixes render incorrectly

Finishes #6646

Commits
-------

b44620d [Form] Ambiguous block prefixes render incorrectly
@weaverryan weaverryan deleted the foaly-nr1-block-prefix-ambiguity branch July 10, 2016 16:44
->add('dueDate', DateType::class, array(

->add('dueDate', 'date', array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been Symfony\Component\Form\Extension\Core\Type\Date, shouldn't it?

wouterj added a commit that referenced this pull request Oct 20, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

use FCQN to reference the form type in add()

fixes #6744 (comment)

Commits
-------

eda0441 use FCQN to reference the form type in add()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants