Skip to content

Conversation

ranqiangjun
Copy link
Contributor

@ranqiangjun ranqiangjun commented Jul 11, 2016

$controller always return false.

$controller = $controllerResolver->getController($request);
$arguments = $argumentResolver->getArguments($request, $controller);

The two lines before the try ... catch should run after:

$request->attributes->add($matcher->match($request->getPathInfo()));

The three lines already exist inside the try ... catch which works fine and properly after removed those two lines.

(http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html)

$controller always return false. 

$controller = $controllerResolver->getController($request);
$arguments = $argumentResolver->getArguments($request, $controller);
The two lines above should run after:
$request->attributes->add($matcher->match($request->getPathInfo()));
@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2016

👍 LGTM

Status: Reviewed

@weaverryan
Copy link
Member

I agree also! Thanks Qiangjun!

@weaverryan weaverryan merged commit 86bb5ac into symfony:master Aug 2, 2016
weaverryan added a commit that referenced this pull request Aug 2, 2016
This PR was merged into the master branch.

Discussion
----------

Fix web/front.php

## $controller always return false.

    $controller = $controllerResolver->getController($request);
    $arguments = $argumentResolver->getArguments($request, $controller);

The two lines before the `try ... catch` should run after:

    $request->attributes->add($matcher->match($request->getPathInfo()));

The three lines already exist inside the `try ... catch` which works fine and properly after removed those two lines.

([http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html](http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html))

Commits
-------

86bb5ac Fix web/front.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants