Fix web/front.php #6748
Merged
Fix web/front.php #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$controller always return false. $controller = $controllerResolver->getController($request); $arguments = $argumentResolver->getArguments($request, $controller); The two lines above should run after: $request->attributes->add($matcher->match($request->getPathInfo()));
|
👍 LGTM Status: Reviewed |
|
I agree also! Thanks Qiangjun! |
weaverryan
added a commit
that referenced
this pull request
Aug 2, 2016
This PR was merged into the master branch.
Discussion
----------
Fix web/front.php
## $controller always return false.
$controller = $controllerResolver->getController($request);
$arguments = $argumentResolver->getArguments($request, $controller);
The two lines before the `try ... catch` should run after:
$request->attributes->add($matcher->match($request->getPathInfo()));
The three lines already exist inside the `try ... catch` which works fine and properly after removed those two lines.
([http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html](http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html))
Commits
-------
86bb5ac Fix web/front.php
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$controller always return false.
The two lines before the
try ... catchshould run after:The three lines already exist inside the
try ... catchwhich works fine and properly after removed those two lines.(http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html)