[FormComponent]Fix wrong mention in side note #6885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rendler-denis
commented
Aug 17, 2016
rendler-denis
commented
- fix wrong mention in side note for ValidationListener. It mentioned that the ValidationListener will also update the normalized representation as well as the view representations actions which it doesn't perform. The listener's only role is to validate the updated object
- fix wrong mention in side note for ValidationListener. It mentioned that the ValidationListener will also update the normalized representation as well as the view representations actions which it doesn't perform. The listener's only role is to validate the updated object
|
I tried to do a PR into the 2.7 branch but it showed me about 300+ files changed so I wasn't certain if it would be ok :) |
|
👍 We should be able to easily merge this into 2.7 with the merge tool. |
|
Good catch, thanks @rendler-denis. |
xabbuh
added a commit
that referenced
this pull request
Sep 21, 2016
…nis) This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #6885). Discussion ---------- [FormComponent]Fix wrong mention in side note - fix wrong mention in side note for ValidationListener. It mentioned that the ValidationListener will also update the normalized representation as well as the view representations actions which it doesn't perform. The listener's only role is to validate the updated object Commits ------- 84a70fd [FormComponent]Fix wrong mention in side note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.