Fixed Request Factory Example #6939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Feb 27, 2017
| @@ -303,7 +304,7 @@ PHP callable that is able to create an instance of your ``Request`` class:: | |||
| array $server = array(), | |||
| $content = null | |||
| ) { | |||
| return SpecialRequest::create( | |||
| return new SpecialRequest( | |||
There was a problem hiding this comment.
Why not keeping the static method?
| @@ -293,6 +293,7 @@ methods or changing some default behavior might help. In that case, register a | |||
| PHP callable that is able to create an instance of your ``Request`` class:: | |||
|
|
|||
| use Symfony\Component\HttpFoundation\Request; | |||
| use AppBundle\Classes\SpecialRequest; | |||
There was a problem hiding this comment.
Maybe Http would be more appropriate as namespace than Classes?
|
Thank you @vdambeck. |
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #6939). Discussion ---------- Fixed Request Factory Example The Request Factory Example dosen't work anymore. I change the example code. So it will work now. Commits ------- c877fce change request factory example code
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Request Factory Example dosen't work anymore.
I change the example code. So it will work now.