[Config] articles chronology in comment #6967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Loading resources" is next to currnet section "Caching based on Resources", not previews
ghost
changed the title
xabbuh
reviewed
Sep 21, 2016
components/config/caching.rst
Outdated
| @@ -38,7 +38,7 @@ should be regenerated:: | |||
| $resources = array(); | |||
|
|
|||
| foreach ($yamlUserFiles as $yamlUserFile) { | |||
| // see the previous article "Loading resources" to | |||
| // see the next article "Loading resources" to | |||
There was a problem hiding this comment.
Actually, it isn't the very next article neither (which is "Defining and Processing Configuration Values"). So I think we can better reword the comment by simply removing "previous". What do you think?
There was a problem hiding this comment.
Good idea. It will be less confusing
HeahDude
approved these changes
Feb 27, 2017
|
Good catch, thanks @karzz. |
xabbuh
added a commit
that referenced
this pull request
Mar 3, 2017
…iluz) This PR was submitted for the 3.1 branch but it was merged into the 3.2 branch instead (closes #6967). Discussion ---------- [Config] articles chronology in comment "Loading resources" is next to currnet section "Caching based on Resources", not previews Commits ------- e803a34 Finished this PR 9ca8627 section chronology in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Loading resources" is next to currnet section "Caching based on Resources", not previews