Improved Redirecting paragraph of Testing page #7098
Conversation
FrancescoBorzi
force-pushed
the
2.7-testing
branch
2 times, most recently
from
1b07199
to
d066ca8
Compare
| @@ -505,7 +505,7 @@ afterwards with the ``followRedirect()`` method:: | |||
| $crawler = $client->followRedirect(); | |||
|
|
|||
| If you want the client to automatically follow all redirects, you can | |||
| force him with the ``followRedirects()`` method:: | |||
| force him by calling the ``followRedirects()`` method before performing the request:: | |||
There was a problem hiding this comment.
Love your addition! If you have the time, please make one more minor change in this change: Change "him" to "them". We want to be as gender-neutral as possible in the docs :)
There was a problem hiding this comment.
right, done!
|
👍 |
| @@ -505,7 +505,7 @@ afterwards with the ``followRedirect()`` method:: | |||
| $crawler = $client->followRedirect(); | |||
|
|
|||
| If you want the client to automatically follow all redirects, you can | |||
There was a problem hiding this comment.
@ShinDarth thanks for this improvement. I like it ... but I still think that the original phrase is not very good. What if we reword it as follows:
You can make the client to automatically follow all redirects by
calling the ``followRedirects()`` method before making the first request::
There was a problem hiding this comment.
ok but are you sure that it should be made before the first request? I would say it simply should be made before the requests that needs to automatically follow the redirect
There was a problem hiding this comment.
👍 You are right. It's common to call this before the first request ... but it's not mandatory at all! Thanks.
FrancescoBorzi
force-pushed
the
2.7-testing
branch
from
d066ca8
to
91bffcb
Compare
|
Thank you @ShinDarth. |
This PR was merged into the 2.7 branch. Discussion ---------- Improved Redirecting paragraph of Testing page Commits ------- 91bffcb Improved Redirecting paragraph of Testing page
No description provided.