-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Framework templating documentation #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…refixing Versioned path prefixes are useful for CDN's that do not support cache-busting via query strings. This seemed small enough to add as a tip, although it might be better expanded into a cookbook article (and this tip reduced to a "see cookbook" link). Also added a note about required escaping of percentage signs in the option value.
Woh, this is awesome! Can you explain what the new changes are for 2.1? Ideally (might not be possible), we'd make this PR for the 2.0 branch, merge it up to master (i.e. 2.1), and then add some "added in 2.1" tags, which look like this:
Is that possible? Or are the new changes too fundamental to isolate out like this? Either way, I'll want to backport at least some of this to the 2.0 branch. Thanks Jeremy! |
The only 2.1 change was disabling deep merges for the Perhaps the easiest thing to do would be to merge this to master (I assume that's bleeding-edge and 2.1 docs), as well as to 2.0 and then make a separate commit that simply deletes the note block from the 2.0 branch? Otherwise, perhaps I should split my last commit up into two, and you can cherry-pick all but the "note" commit into 2.0? Let me know. |
@jmikola doing a new commit in 2.0 will not work as it would then be merged into master on the next update |
I decided to gloss over the details of how a single base URL is selected from a collection when generating an asset's path, as the internal behavior of UrlPackage is just that.
Created #715 with all of the 2.0-specific documentation changes. After that's merged to 2.0, and then down to master, I'll repurpose this to add the 2.1-specific tip for |
Framework templating documentation
Adds documentation for
assets_base_url
andassets_verison_format
, including recently-changed behavior from PR 2197.Also snuck in some other random corrections with this branch.
Please let me know if the any of the footnote link or note/tip box syntax is off. I wasn't sure how to test the formatting locally (don't have sphinx setup), so I just based things off of other examples in the docs.