make strict the default option for choice validation #7214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Dec 3, 2016
| **type**: ``boolean`` **default**: ``false`` | ||
| **type**: ``boolean`` **default**: ``true`` | ||
|
|
||
| The validator will also check the type of the input value. |
There was a problem hiding this comment.
Wouldn't it make more sense to keep the current description? Or at least tell a bit about what "check the type" means?
| this value is passed to as the third argument to the PHP :phpfunction:`in_array` | ||
| method when checking to see if a value is in the valid choices array. | ||
| Setting the strict option of the `Choice` Constraint to `false` has been | ||
| deprecated as of Symfony 3.2 and the option will be changed to `true` as of 4.0. |
There was a problem hiding this comment.
As it's reStructed Text, you have to use double backticks for literals: ``true``
Also, I suggest removing the literal from "Choice constraint". Literals kinda break the read flow, which makes things a little harder to read.
xabbuh
added a commit
that referenced
this pull request
Jan 10, 2017
xabbuh
added a commit
that referenced
this pull request
Jan 11, 2017
* 3.2: (22 commits) Rename "console tasks" to "console commands" [Workflow] Add tip for workflow configuration default values Reflect private to hidden renaming in the file name Reflect renaming from private to hidden Added an article about private console commands Updated the explanation about framework.ide [#7214] fix option's default value strict default option for choice validation Reworded the user checker aliases explanation Remove duplicate use operator [Fix][httpKernel] Wrong links [Fix][Console] Missing autoloading by Composer Revert "Fixed wrong inheritance information" [#7318] Removing unnecessary word Minor fixes Explain what is the Symfony Core team Added the references to security vulnerabilities discovered in 2016 Improve configuration example text indents update year in license template describe should have an 's' on the end ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7171.