Skip to content

Improved code example of prepend method #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improved code example of prepend method #7241

wants to merge 2 commits into from

Conversation

a-ast
Copy link
Contributor

@a-ast a-ast commented Dec 10, 2016

  • Split the comment into readable parts. At the moment 2 different sentences combined in one without a comma or a dot. It is difficult to catch a sense of '...acme_something and acme_other note that if the user...'
  • Additionally, added a comment with a file path to put reader in the context of this example

@a-ast
Improved code example of prepend method
2b5fa93 
- Split the comment into readable parts. At the moment 2 different sentences combined in one without a comma or a dot. It is difficult to catch a sense of '...acme_something and acme_other note that if the user...' 
- Additionally, added a comment with a file path to put reader in the context of this example
javiereguiluz
javiereguiluz approved these changes Dec 12, 2016
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it's more readable now.

Thanks @a-ast

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2016

Thank you @a-ast.

xabbuh added a commit that referenced this pull request Dec 12, 2016
@xabbuh
minor #7241 Improved code example of prepend method (a-ast, javiere…
881857e 
…guiluz)

This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7241).

Discussion
----------

Improved code example of `prepend` method

- Split the comment into readable parts. At the moment 2 different sentences combined in one without a comma or a dot. It is difficult to catch a sense of '...acme_something and acme_other note that if the user...'
- Additionally, added a comment with a file path to put reader in the context of this example

Commits
-------

000f430 Minor change
2271059 Improved code example of `prepend` method
@xabbuh xabbuh closed this Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-ast @xabbuh @javiereguiluz @carsonbot