Skip to content

Conversation

javiereguiluz
Copy link
Member

This replaces #6610.

@Jean85
Copy link
Contributor

Jean85 commented Feb 16, 2017

LGTM 👍

Status: reviewed

method can return this alias (instead of a class name).
In earlier versions of Symfony, the tag required an ``alias`` key (usually
set to the class name). This ``alias`` is now optional, but if you define
it, your constraint's ``validateBy()`` method must return the same value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we always had a typo here. The method's name is validatedBy().

@xabbuh
Copy link
Member

xabbuh commented Feb 17, 2017

@javiereguiluz This is targeted for 2.7, right?

@javiereguiluz javiereguiluz changed the base branch from master to 2.7 February 17, 2017 08:51
@javiereguiluz
Copy link
Member Author

Yes! I've changed the base to 2.7. Thanks.

@xabbuh
Copy link
Member

xabbuh commented Feb 28, 2017

Thank you @javiereguiluz.

xabbuh added a commit that referenced this pull request Feb 28, 2017
This PR was squashed before being merged into the 2.7 branch (closes #7489).

Discussion
----------

Reworded a note about custom constraints

This replaces #6610.

Commits
-------

a9d59fd Reworded a note about custom constraints
@xabbuh xabbuh closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants