Update best_practices/templates.rst #7902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
May 16, 2017
| tags: [twig.extension] | ||
| Your application will :ref:`autoconfigure <services-autoconfigure>` your twig | ||
| extension and inject a ``Markdown`` instance in it thanks to | ||
| :doc:`autowiring </service_container/autowiring>`. |
There was a problem hiding this comment.
After #7906, I have something we can link to that talks about this "default" config. I'm linking to it everywhere pretty consistently. See https://github.com/symfony/symfony-docs/pull/7906/files#diff-37bf298125afc3dde92bb3907795a9e7R291 for an example
There was a problem hiding this comment.
I added it in sha: 2a7f91d :)
There was a problem hiding this comment.
I like it, thanks 👍
|
One little comment, but 👍 Status: Reviewed |
weaverryan
added a commit
that referenced
this pull request
May 16, 2017
This PR was merged into the master branch. Discussion ---------- Update best_practices/templates.rst First example of a doc asserting we're using the 3.3 SE (#7877 (comment)). Commits ------- 8769a30 Update best_practices/templates.rst
|
Thank you @GuilhemN! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First example of a doc asserting we're using the 3.3 SE (#7877 (comment)).