Skip to content

Minor reword of the intro of the routing/conditions article #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2017
Merged

Minor reword of the intro of the routing/conditions article #8019

merged 1 commit into from
Jun 13, 2017

Conversation

javiereguiluz
Copy link
Member

Two changes:

  • Starting with "As you've seen..." is wrong because each article should be self-contained.
  • "wildcards" is not OK because in other docs we mostly use "placeholders"

@xabbuh xabbuh added this to the 2.7 milestone Jun 11, 2017
@weaverryan weaverryan merged commit 5bda060 into symfony:2.7 Jun 13, 2017
weaverryan added a commit that referenced this pull request Jun 13, 2017
@weaverryan
minor #8019 Minor reword of the intro of the routing/conditions artic…
8ae7973 
…le (javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Minor reword of the intro of the routing/conditions article

Two changes:

* Starting with "As you've seen..." is wrong because each article should be self-contained.
* "wildcards" is not OK because in other docs we mostly use "placeholders"

Commits
-------

5bda060 Minor reword of the intro of the routing/conditions article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @xabbuh @weaverryan @carsonbot