Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the screenshot of exceptions in dev environment #8117

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7778.

@apfelbox
Copy link
Contributor

apfelbox commented Jul 4, 2017

Not sure whether this is a thing that is currently in use in the symfony docs, but minifying this image reduces its size by around 50%.

2017-07-04 at 17 33

Tool: https://tinypng.com/

@javiereguiluz
Copy link
Member Author

@apfelbox is that a lossless compression? Because I always use ImageOptim to compress images (without losing quality) and this was the best it could do:

image-compression

@apfelbox
Copy link
Contributor

apfelbox commented Jul 4, 2017

It is not lossless, but you can compare the images and in several hundred images I minified I had exactly 1 image that had a visual degradation.

So technically not lossless, but visually sort-of-lossless.

@javiereguiluz
Copy link
Member Author

@apfelbox you are right ... the visual differences I see between the two versions are minimal, so I'm using your compressed version. Thanks!

@xabbuh xabbuh added this to the 3.3 milestone Jul 7, 2017
@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Jul 7, 2017
…javiereguiluz)

This PR was squashed before being merged into the 3.3 branch (closes #8117).

Discussion
----------

Updated the screenshot of exceptions in dev environment

This fixes #7778.

Commits
-------

2192440 Updated the screenshot of exceptions in dev environment
@xabbuh xabbuh closed this Jul 7, 2017
xabbuh added a commit that referenced this pull request Jul 7, 2017
…iluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Updated the screenshot of deprecation messages

While updating the exception screenshot in #8117 I noticed that this old deprecation screenshot was never updated for Symfony 2.8+.

Commits
-------

c62d712 Updated the screenshot of deprecation messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants