Skip to content

Fix minor typo #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix minor typo #8134

wants to merge 2 commits into from

Conversation

tobemedia
Copy link
Contributor

No description provided.

xabbuh
xabbuh reviewed Jul 9, 2017
View reviewed changes
frontend/encore/versus-assetic.rst Outdated
@@ -23,6 +23,7 @@ So what are the differences between Assetic and Encore?
| Loads JS Modules? [1]_ | No | Yes |
+--------------------------+-------------------------------+-------------------------+
| Load CSS Deps in JS? [1] | No | Yes |

Copy link
Member

@xabbuh xabbuh Jul 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should be reverted

@xabbuh xabbuh added this to the 3.3 milestone Jul 9, 2017
@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2017

Good catch, thanks @tobemedia.

xabbuh added a commit that referenced this pull request Jul 11, 2017
@xabbuh
minor #8134 Fix minor typo (tobemedia)
85880c6 
This PR was squashed before being merged into the 3.3 branch (closes #8134).

Discussion
----------

Fix minor typo

Commits
-------

6beff5e Fix minor typo
@xabbuh xabbuh closed this Jul 11, 2017
@tobemedia tobemedia deleted the patch-4 branch July 11, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tobemedia @xabbuh @carsonbot