Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation input+regions options in TimezoneType #8223

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Documentation input+regions options in TimezoneType #8223

merged 3 commits into from
Jan 3, 2018

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jul 25, 2017

regions
~~~~~~~

**type**: ``int`` **default**: ``DateTimeZone::ALL``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\DateTimeZone::ALL

@HeahDude HeahDude added this to the 3.4 milestone Jul 25, 2017
ogizanagi added a commit to symfony/symfony that referenced this pull request Sep 16, 2017
…0NL)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add input  + regions options to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#8223

I want to use `\DateTimeZone` as a model format, with only european timezones in the form available. Hence the new options.

Commits
-------

183307b [Form] Add input  + regions options to TimezoneType
@ro0NL
Copy link
Contributor Author

ro0NL commented Oct 3, 2017

ping @HeahDude

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 28, 2017

Guys.. this should be merged really :) cc @javiereguiluz

@javiereguiluz
Copy link
Member

I'm sorry it wasn't merged before. The problem is that currently doc mergers have more work than they can handle. It will take some time to merge this. Please bear with us in these stressful moments before the Symfony 4 release. 🙏

@javiereguiluz
Copy link
Member

Thank you Roland.

@javiereguiluz javiereguiluz merged commit 99f5f3e into symfony:3.4 Jan 3, 2018
javiereguiluz added a commit that referenced this pull request Jan 3, 2018
…L, javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Documentation input+regions options in TimezoneType

See symfony/symfony#23648

Commits
-------

99f5f3e Minor typo
d6611eb Update timezone.rst
de490ca Update timezone.rst
@ro0NL ro0NL deleted the patch-1 branch January 27, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants