Improve service container parameters section #8399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Good suggestion. Let's see if this helps the beginners :) status: reviewed |
xabbuh
approved these changes
Sep 19, 2017
|
Thank you @zelazowy. |
xabbuh
added a commit
that referenced
this pull request
Sep 22, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #8399). Discussion ---------- Improve service container parameters section I've noticed that many young programmers inject the whole container to the service only for fetching parameters, and I think it's because of missing example for using an injected parameter in the service but existing example for doing so in the controller. Commits ------- fbaeccf improve service container parameters section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that many young programmers inject the whole container to the service only for fetching parameters, and I think it's because of missing example for using an injected parameter in the service but existing example for doing so in the controller.