Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve service container parameters section #8399

Closed

Conversation

@zelazowy
Copy link

@zelazowy zelazowy commented Sep 15, 2017

I've noticed that many young programmers inject the whole container to the service only for fetching parameters, and I think it's because of missing example for using an injected parameter in the service but existing example for doing so in the controller.

@wouterj
Copy link
Member

@wouterj wouterj commented Sep 19, 2017

👍 Good suggestion. Let's see if this helps the beginners :)

status: reviewed

xabbuh
xabbuh approved these changes Sep 19, 2017
@xabbuh xabbuh added this to the 2.7 milestone Sep 19, 2017
@xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 22, 2017

Thank you @zelazowy.

xabbuh added a commit that referenced this issue Sep 22, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #8399).

Discussion
----------

Improve service container parameters section

I've noticed that many young programmers inject the whole container to the service only for fetching parameters, and I think it's because of missing example for using an injected parameter in the service but existing example for doing so in the controller.

Commits
-------

fbaeccf improve service container parameters section
@xabbuh xabbuh closed this Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants