doc(http_foundation) #8769
Closed
doc(http_foundation) #8769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constructor method. Fix symfony#8768.
javiereguiluz
approved these changes
Dec 4, 2017
There was a problem hiding this comment.
@Sydney-o9 thanks for reporting this issue in the first place and thanks for fixing it. Congrats on your first Symfony Docs contribution.
(Note: the Travis CI error is unrelated and was fixed in another PR).
|
No thank you guys. Keep up the good work you are awesome. |
|
Thank you @Sydney-o9! I've merged this into the 2.7 branch and tthe fix will be merged up to all branches. Welcome as a Symfony docs contributor ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create()instead of constructor method.Fix #8768.