Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form cache typos #92

Closed
wants to merge 1 commit into from
Closed

Form cache typos #92

wants to merge 1 commit into from

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Feb 4, 2011

Some minor typos in cache and forms chapters

@weaverryan
Copy link
Member

Data is always plural, but using it correctly still sounds really strange in English. It might be best to avoid it in this way - I've modified the language slightly. Also, isn't it better to say that we're validating the object and not the data?

One question - we say "If a POST request...", but there's no actual if statement in the action. Should the wording be written as if it only handles the form submit or should there be an if statement added? Put better, which pattern should we be teaching the reader?

Thanks

xabbuh added a commit that referenced this pull request Jul 28, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Make usage of "The" in the edition list consistent

Commits
-------

89dc030 Make usage of "The" in the edition list consistent
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants