Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] PlantUML Dump documentation #9220

Closed
wants to merge 1 commit into from
Closed

[Workflow] PlantUML Dump documentation #9220

wants to merge 1 commit into from

Conversation

Plopix
Copy link
Contributor

@Plopix Plopix commented Feb 7, 2018 •
edited
Loading

Documentation related to symfony/symfony#24705
This PR aims to explain that the PlantUML dump format is available.

Platform.sh URL: http://pr-9220-x7nzdnq-6qmocelev2lwe.eu.platform.sh/workflow/dumping-workflows.html

@Plopix Plopix changed the title [Workflow] PlantUML Dump documentation [WIP] [Workflow] PlantUML Dump documentation Feb 7, 2018
@Plopix Plopix changed the base branch from master to 4.0 February 7, 2018 07:21
@Plopix Plopix changed the title [WIP] [Workflow] PlantUML Dump documentation [Workflow] PlantUML Dump documentation Feb 7, 2018
@Plopix Plopix mentioned this pull request Feb 7, 2018
Merged
@Plopix
Copy link
Contributor Author

Plopix commented Feb 7, 2018

Ok ready to review. cc @lyrixx @Nyholm

@javiereguiluz javiereguiluz added this to the 4.1 milestone Feb 7, 2018
javiereguiluz
javiereguiluz approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It's nicely explained. @Plopix thanks for implementing this feature and providing the docs too.

Nyholm
Nyholm approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you

lyrixx
lyrixx approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks you.

But warning, the target branch 4.0 is wrong. it should be master. Could you update it ? Thanks

@javiereguiluz
Copy link
Member

@Plopix it's true that the branch should be master (as @lyrixx said) but don't worry, we can change the branch when merging your work. There's nothing left to do on your side. Thanks!

@javiereguiluz
Copy link
Member

Thanks Sébastien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@lyrixx lyrixx lyrixx approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Plopix @javiereguiluz @lyrixx @Nyholm @carsonbot