[Process] allow writing "prepared" command line. #9295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 19, 2018
…nes (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [Process] Allow writing portable "prepared" command lines | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23778 | License | MIT | Doc PR | symfony/symfony-docs#9295 This give the opportunity to create process commands that allow to changes only the values instead of changing the code. Commits ------- d1e4f48 [Process] Allow writing portable "prepared" command lines
staabm
reviewed
Feb 19, 2018
| $process = new Process('/usr/bin/php {{ phpFile }}'); | ||
| $process->run(null, array('phpFile' => 'worker.php')); | ||
|
|
||
| Which means that you can use placeholder in order to have a process that can be changed only with the values and without changing the php code. |
There was a problem hiding this comment.
it should be noted whether the user of this api is still responsible to escape the passed in data or whether the console component will take care of escaping (e.g. > character or similar)
|
We need to rework the feature, so this is not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#24763