Skip to content

Conversation

guillbdx
Copy link

@guillbdx guillbdx commented Mar 5, 2018

No description provided.

@Simperfit
Copy link
Contributor

This one is not needed, the documentation team will take care of merging the 3.4 branch in the 4.0 and master branch ;).

Thanks for the contribution anyway!

@xabbuh
Copy link
Member

xabbuh commented Mar 6, 2018

@guillbdx Thank you for the PR, but as @Simperfit said we regularly merge branches up. :)

@xabbuh xabbuh closed this Mar 6, 2018
@javiereguiluz
Copy link
Member

@guillbdx thanks for your contribution! As others said, we regularly merge changes from lower to upper branches until we reach master, so this shouldn't be needed.

But I can't remember a recent pull request that made these changes and was merged in lower branches ... so this may be a problem that won't be fixed waiting for the upper branches merges. I'm reopening so we can look closely at this. Thanks!

@javiereguiluz javiereguiluz reopened this Mar 6, 2018
@Simperfit
Copy link
Contributor

Simperfit commented Mar 6, 2018 via email

@xabbuh
Copy link
Member

xabbuh commented Mar 6, 2018

see #9396

@xabbuh xabbuh closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants