Skip to content

Correct typo on best practices #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

Correct typo on best practices #9772

merged 1 commit into from
May 15, 2018

Conversation

kaybie3
Copy link
Contributor

@kaybie3 kaybie3 commented May 15, 2018

No description provided.

javiereguiluz
javiereguiluz approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this issue! Actually when I wrote this I thought it was correct (I mean that I wanted to write too instead of tool). In any case, you are a native English speaker and I'm not, so let's make this change.

@javiereguiluz javiereguiluz added this to the 4.0 milestone May 15, 2018
@javiereguiluz
Copy link
Member

Thanks for this ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 684e692 into symfony:4.0 May 15, 2018
javiereguiluz added a commit that referenced this pull request May 15, 2018
@javiereguiluz
minor #9772 Correct typo on best practices (kaybie3)
5f7eb92 
This PR was merged into the 4.0 branch.

Discussion
----------

Correct typo on best practices

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

684e692 Correct typo on best practices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaybie3 @javiereguiluz @carsonbot