Skip to content

Fix configuration-block not working #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

keichinger
Copy link
Contributor

The :: shorthand in the line before the .. configuration-block:: breaks the entire block.

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix :)

@javiereguiluz
Copy link
Member

Good catch, thanks Kai.

@javiereguiluz javiereguiluz merged commit f952c32 into symfony:4.0 Jun 20, 2018
javiereguiluz added a commit that referenced this pull request Jun 20, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Fix configuration-block not working

The `::` shorthand in the line before the `.. configuration-block::` breaks the entire block.

Commits
-------

f952c32 Fix configuration-block not working
@keichinger keichinger deleted the 4.0 branch June 20, 2018 15:33
@keichinger
Copy link
Contributor Author

@javiereguiluz @HeahDude is the docs site using continuous integration or does it need to be manually deployed?

After changing the lines locally I was re-building the docs and checking out the local copy of https://symfony.com/doc/current/routing/redirect_in_config.html#redirecting-using-a-route and just checked that a <div> with the class configuration-block was generated with proper contents (from the first looks).

Since the local path to the assets is broken and the live version is still broken I'm not sure whether my fix didn't work or if it hasn't been deployed yet? :)

@HeahDude
Copy link
Contributor

Hello @keichinger don't worry, the fix has only been merged in 4.0 for now. Not 4.1 and master, so the corresponding versions of the docs are up to date. We might merge this fix in upper branches as soon as we can.

Thank you :)

@keichinger
Copy link
Contributor Author

Ah great, thank you @HeahDude. I was actually checking the 4.0 version of the docs and it seems like I've either hit a cached version or it wasn't live yet. But now it's indeed fixed for me :)

Thanks again for your time :) Really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants