[Console] Fixed the compatibility with HHVM #10000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.
The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy.
|
and 10000 is for me 😄 |
|
1️⃣ 0️⃣ 0️⃣ 0️⃣ 0️⃣ ❗ |
|
👍 |
|
Congratulation @stof for pull request number 10000! |
fabpot
added a commit
that referenced
this pull request
Jan 11, 2014
This PR was squashed before being merged into the 2.3 branch (closes #10000). Discussion ---------- [Console] Fixed the compatibility with HHVM | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy. This PR currently includes #9999 in it, to have a working HHVM build on Travis. Commits ------- ac1ba81 [Console] Fixed the compatibility with HHVM
|
👍 |
|
👍 |
|
all of this is nothing but the outcome of a small start fixing a typo https://github.com/symfony/symfony/commits/master?author=stof&page=7 three years ago by someone that likes to read locs. As they used to say back in the time within the mailing list and the IRC channel, |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2014
… terminal width (stof) This PR was merged into the 2.3 branch. Discussion ---------- [Console] Fixed the rendering of exceptions on HHVM with a terminal width | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default. Commits ------- 6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width
|
@stof : hhvm is 64bits compliant now : facebook/hhvm@1bd7e47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy.
This PR currently includes #9999 in it, to have a working HHVM build on Travis.