[VarDumper] fix handling of non-UTF8 strings #13441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 18, 2015
nicolas-grekas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13440 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
fix-13440
branch
6 times, most recently
from
b962d85 to
de2f2a6
Compare
|
@stof review welcomed, PR is ready (failures are not related) |
nicolas-grekas
force-pushed
the
fix-13440
branch
from
de2f2a6 to
79ed36d
Compare
| * | ||
| * @param string $charset The default character encoding to use for non-UTF8 strings. | ||
| * | ||
| * @return The previous charset. |
There was a problem hiding this comment.
missing type: @return string The previous charset
nicolas-grekas
force-pushed
the
fix-13440
branch
5 times, most recently
from
94f5a5e to
0cf6153
Compare
nicolas-grekas
force-pushed
the
fix-13440
branch
from
0cf6153 to
4205559
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 2, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [VarDumper] fix handling of non-UTF8 strings | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13440 | License | MIT | Doc PR | - Commits ------- 4205559 [VarDumper] fix handling of non-UTF8 strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.