InlineFragmentRenderer should create subrequest based on input request

[ruudk]

In our project we have created our own Request object. This works great except when we are doing fragment renders in twig:

{{ render(controller("AppBundle:Homepage:events")) }}

But now

public function eventsAction(My\Custom\Request $request)

fails because it is given a Symfony\Component\HttpFoundation\Request.

I found out that the problem is in

symfony/src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php

Line 133 in 161f12c

$subRequest = Request::create($uri, 'get', array(), $cookies, array(), $server);

If I change

$subRequest = Request::create($uri, 'get', array(), $cookies, array(), $server);

to

$subRequest = $request::create($uri, 'get', array(), $cookies, array(), $server);

It works :)

Is this by design or can I submit a PR to fix this?

[linaori]

You have the object so you should be able to call it as $request->create() in this case.

I think the underlying problem is, that we need a RequestFactory of some sort and not have the request being responsible for this. This way the Request is nothing more than an implementation such as the PSR variant.

[ruudk]

Yep but create is static. That's why I call it static.

[linaori]

As far as I know it's perfectly legit to call a static method from an object PoV.