Skip to content

[Hack Day] Issue for newcomers (4) #18091

@javiereguiluz

Description

@javiereguiluz

NOTE this issue has been prepared for the Virtual Symfony Hack Day which will take place on March 12th. Please, don't create a pull request for this issue before the Hack Day.


Introduction

This issue is exclusively for developers who have never contributed to Symfony. It's very easy to solve, so you just need to follow the contribution process to get it merged. Ryan Weaver (@weaverryan) will host a live video tutorial about this contribution process during the Virtual Hack Day. Meanwhile, you can read the Symfony Contribution Guide.

The problem to solve

  1. In the Symfony 2.3 branch, locate the file src/Symfony/Bridge/Propel1/Tests/Form/ChoiceList/ModelChoiceListTest.php.

  2. There is a method which wrongly includes choosen instead of chosen in its name and in some of its variables.

  3. The solution is to:

3.1) (in line 189) Rename the method testDifferentEqualObjectsAreChoosen() to testDifferentEqualObjectsAreChosen().

3.2) (in lines 203, 205, 206) Rename the $choosenItem variable to $chosenItem

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions