ACL + DoctrineMigrationsBundle

[rubensayshi]

The app/console doctrine:migrations:diff generates a migration to drop all the ACL tables.

Now I'm pretty sure we can safely say that a develop should always check the generated migrations ...
Nonetheless this behavory can be anoying and is defenatly not intended!

PS . I'm not really sure where this issue should go but I think this is more related to ACL then the bundle.
Apart from that I think the ACL has some serious issues with being decoupled while instead it should be strongly integerated into the doctrine bundle.

[acasademont]

+1 for this, i made a comment on the Google Groups list a couple of months ago, let's see if i can do something in the code

[lsmith77]

@schmittjoh ping

[schmittjoh]

I had submitted a patch to solve this which was rejected. It's somewhere in my symfony fork though.

[vicb]

@schmittjoh could you give the ref to your PR / branch ?

[schmittjoh]

Unfortunately not, it's incorporated into my master branch. But since it
already was rejected, I guess we can close it.

On Thu, Mar 8, 2012 at 2:36 PM, Victor Berchet <
reply@reply.github.com

wrote:

@schmittjoh could you give the ref to your PR / branch ?

---

Reply to this email directly or view it on GitHub:
#2091 (comment)

[vicb]

Do you remember the reason why this was rejected by any chance ? (I can't find the closed PR with GH)

[schmittjoh]

I believe it was performance, but don't know for sure, was like 7 or 8
months ago.

On Thu, Mar 8, 2012 at 3:15 PM, Victor Berchet <
reply@reply.github.com

wrote:

Do you remember the reason why this was rejected by any chance ? (I can't
find the closed PR with GH)

---

Reply to this email directly or view it on GitHub:
#2091 (comment)

[vicb]

#1313 ?

[schmittjoh]

Yes, that looks like it.

[vicb]

So I guess the problem was mainly that the PR has 2 not related commits (am I right here ?) + some mis-understanding. Would you mind opening a new PR with the second commit only ?

[schmittjoh]

I'd appreciate if someone else can cherry-pick the commit, and try to get
it in. I don't have that much time unfortunately.

On Fri, Mar 9, 2012 at 3:18 AM, Victor Berchet <
reply@reply.github.com

wrote:

So I guess the problem was mainly that the PR has 2 not related commits
(am I right here ?) + some mis-understanding. Would you mind opening a new
PR with the second commit only ?

---

Reply to this email directly or view it on GitHub:
#2091 (comment)

[vicb]

I can do that if you confirm that the first commit is not required.

[memphys]

Was the problem really fixed? I still have the issue in version 2.0.16. Any ideas on how to overcome this?

[stof]

@memphys it was fixed, but for 2.1

[memphys]

@stof any chances it will be back-ported to 2.0?

[stof]

@memphys no. It relies on a new feature introduced in 2.1, and new features are never backported.

[memphys]

@stof ok, understood. Thanks!