Confusion regarding framework.trusted_proxies in Symfony 3.3

[alcaeus]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	yes
RFC?	no
Symfony version	3.3-dev

According to the current Symfony 3.3 upgrading document, the framework.trusted_proxies parameter config option has been deprecated and will be removed in Symfony 4.0. However, according to the commit in question, the option has been removed in 3.3 already (unless you trust that comment a few lines above where it still says the parameter is deprecated).

What's the state of this? Is the configuration option deprecated in 3.3 or is it already removed? If so, what's the reason for this BC break?

[sstok]

The option itself is no longer supported. Setting it gives a helpful message about this change.
But in 4.0 this will be completely removed, and no upgrade message is shown anymore.

@deprecated in version 3.3, to be removed in 4.0 is to help developers find old code when working on the next major version.

To be clear, it was previously deprecated. But because of security problems it's completely removed now, which is exceptional for Symfony.

[alcaeus]

Thanks for the explanation. Should the UPGRADE document for 3.3 be updated to mention the option being removed, not deprecated? If so, I can create a PR.

[sstok]

Oh wait, the UPGRADE in the root is not up-to-date with the one of the FrameworkBundle.

[sstok]

See #22507

[alcaeus]

Thank you, closing since it's being fixed by the pull request.