[RFC] Webprofiler DX improvement

[Toflar]

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	yes
Symfony version	x

Hey everyone.

I often find myself using dump() for quick debugging sessions and apparently a lot of developers do so.

When you have a lot of subrequests, ESI and or ajax stuff, it's kind of hard to find the correct profile in the profile overview. What do you think of extending the list by just indicating which profiles actually do contain any debug information? Like so maybe:

And if you like this, how could we implement that because right now, no data from any specific data collector is added to the index file? Ideas anyone?

[sroze]

What if the sub-requests were within the main request's profile? (when displaying the lines)

[nicolas-grekas]

Looks like a good idea to me.

[Toflar]

BTW, I'm happy to work on this. Just not sure how flexible this has to be. Like implementing another interface so every data collector can add another column there or if the debug one is just fine hardcoded.

[lyrixx]

BTW, this is not really related, but It looks like the IP column is not useful since the profiler is only available to localhost. Of course I know it's possible to make it available to everyone bit still.

[kiler129]

@lyrixx Actually it's not useless. I have real life scenario in the office: other developers are asking questions sending a link. Often times when I look at the error I click throughout their profiler - I want to see which requests are mine and which are theirs.

[althaus]

Would be great if this could also be shown in the request panel of the toolbar.

[stephanvierkant]

There is even more information that could be relevant, like performance metrics, (deprecation) logs count, Doctrine query (time, count), method type (xhr, fetch), etc.

Showing all information would make the page a mess, but there is already some logic to give the toolbar icons an other color if something's wrong (yellow/red). Maybe use that logic to show extra information in the profile list?

[stof]

@stephanvierkant making the toolbar item red or green is something controlled by each panel when rendering them item. There is no way to know what this panel uses to decide that. So we cannot really build that info in this list, where we don't even load the full data for each listed profile.

[Simperfit]

@Toflar Do you time to work on this ?

[althaus]

or if the debug one is just fine hardcoded.

I'd be happy with just this.

[carsonbot]

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?