Display only error 500, when you have the wrong configuration in debug mode.

[ikakarov]

Symfony version(s) affected: 4.4.*

Description
When you have the wrong configuration, instead of showing exceptions, an 500 page is displayed.
This problem does not depend on the environment.

How to reproduce
Just set malformed *.ymal file something like this :

# config/routes/annotations.yaml
;321-

[nicolas-grekas]

What else would you expect? If the app is broken, a 500 is the correct display, isn't it?
If you mean that you'd expect a nice customized error page, that's not possible: because the config is broken, the nice error page cannot be configured...

[blowski]

In debug mode, it shows a LoaderLoadException, telling you which file contains malformed YAML.

ParseException > InvalidArgumentException > LoaderLoadException
HTTP 500 Internal Server Error 

The file "config/routes/annotations.yaml" does not contain valid YAML in config/routes/annotations.yaml (which is loaded in resource "config/routes/annotations.yaml").

You can't compile the container, so you can't register an ExceptionListener that would do anything else. I'm not sure how you could do anything else at the Symfony level. You could use your webserver (e.g. nginx or Apache) to intercept 500 errors and show something more end-user friendly, but I'd first try to change the workflow so I don't need to handle broken YAML files in production.

[ikakarov]

!!! Sorry for may very bad english !!!

@nicolas-grekas I expect at least two things:

1. possability to see errors in debug mode.
2. possability to change error page.

This is a very annoying problem because not all errors are displayed.

@blowski It is on symfony level. error-hanlder composent overwrites all server and php configurations.

when you have error in routes/*.yaml if you have this page:

This page generated in Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer and not correct pass $debug __construct parameter.

After small but very stupid fix something like this :

#vendor/symfony/error-handler/ErrorRenderer/HtmlErrorRenderer.php
...
 /**
     * @param bool|callable $debug        The debugging mode as a boolean or a callable that should return it
     * @param bool|callable $outputBuffer The output buffer as a string or a callable that should return it
     */
    public function __construct($debug = false, string $charset = null, $fileLinkFormat = null, string $projectDir = null, $outputBuffer = '', LoggerInterface $logger = null)
    {

        if (!\is_bool($debug) && !\is_callable($debug)) {
            throw new \TypeError(sprintf('Argument 1 passed to "%s()" must be a boolean or a callable, "%s" given.', __METHOD__, \is_object($debug) ? \get_class($debug) : \gettype($debug)));
        }

        if (!\is_string($outputBuffer) && !\is_callable($outputBuffer)) {
            throw new \TypeError(sprintf('Argument 5 passed to "%s()" must be a string or a callable, "%s" given.', __METHOD__, \is_object($outputBuffer) ? \get_class($outputBuffer) : \gettype($outputBuffer)));
        }
##< FORCE CHECK  DEBUG ENV
  if(getenv('APP_ENV') != 'prod' 
            OR getenv('APP_DEBUG') == 1
            OR (isset($_SERVER['APP_DEBUG']) AND $_SERVER['APP_DEBUG'] == 1) 
        ){
            $debug = true;
        }
##> FORCE CHECK  DEBUG ENV
        $this->debug = $debug;
        $this->charset = $charset ?: (ini_get('default_charset') ?: 'UTF-8');
        $this->fileLinkFormat = $fileLinkFormat ?: (ini_get('xdebug.file_link_format') ?: get_cfg_var('xdebug.file_link_format'));
        $this->projectDir = $projectDir;
        $this->outputBuffer = $outputBuffer;
        $this->logger = $logI can't overwrite  `error_handler.error_renderer.html` service. In my case i just replace Symfony\Component\ErrorHandler\ErrorRenderer namesapce in composer whit my own file. ger;
    }
...

i have this page :

I can't overwrite error_handler.error_renderer.html service. In my case i just replace Symfony\Component\ErrorHandler\ErrorRenderer namesapce in composer whit my own stupid fix class.

[blowski]

Thanks for the update.

I just did the following:

• clean install of Symfony 4.4
• entered invalid Yaml in config/routes/annotations.yaml
• load in the browser (Symfony webserver)

I get the "nice error page" you showed in your comment, which leads me to think you have a configuration problem. Can you use xdebug (or at least dd(debug_backtrace())) to figure out what's being passed to HtmlErrorRenderer? It sounds like maybe you've got debug mode disabled in dev.

[ikakarov]

@blowski like this ?

  0 => array:7 [▼
    "file" => "/repos/Tutorials/ApiPlatform/PaerOne/lesson1/start/vendor/symfony/error-handler/ErrorHandler.php"
    "line" => 707
    "function" => "__construct"
    "class" => "Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer"
    "object" => Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer {#3637 ▼
      -debug: null
      -charset: null
      -fileLinkFormat: null
      -projectDir: null
      -outputBuffer: null
      -logger: null
    }
    "type" => "->"
    "args" => array:1 [▼
      0 => false
    ]
  ]

[blowski]

Yes, that's really useful, thanks. Go back through the whole backtrace and figure out why debug is either null or false - it should be true in the dev environment.

Some pointers:

1. The .env file should have a line like APP_ENV: dev.
2. In public/index.php you should see something like if($_SERVER['APP_DEBUG']) { Debug::enable(); }.
3. $_SERVER['APP_DEBUG'] is set in config/bootstrap.php.

[yceruto]

Yes, you should be able to see the detailed exception page if the debug mode is enabled only. Please, check the @blowski's comment above.

[ikakarov]

@blowski Everything is standard. The problem is that Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer does not pass parameters when there is a syntax error.

I think the problem is that error_handler.error_renderer.html expects a data request service as a $debug parameter when there is a syntax error.

    <services>
        <service id="error_handler.error_renderer.html" class="Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer">
            <!-- < This is not possible to execute when we have sytax error  -->

            <argument type="service">
                <service>
                    <factory class="Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer" method="isDebug" />
                    <argument type="service" id="request_stack" />
                    <argument>%kernel.debug%</argument>
                </service>
            </argument>
            <!-- This is not possible to execute when we have sytax error  >-->

            <argument>%kernel.charset%</argument>
            <argument type="service" id="debug.file_link_formatter" on-invalid="null" />
            <argument>%kernel.project_dir%</argument>
            <argument type="service">
                <service>
                    <factory class="Symfony\Component\ErrorHandler\ErrorRenderer\HtmlErrorRenderer" method="getAndCleanOutputBuffer" />
                    <argument type="service" id="request_stack" />
                </service>
            </argument>
            <argument type="service" id="logger" on-invalid="null" />
        </service>

        <service id="error_renderer.html" alias="error_handler.error_renderer.html" />
        <service id="error_renderer" alias="error_renderer.html" />
    </services>

[blowski]

I can't reproduce your problem from this side, so I can't really do much to help debug. For me, with a clean install running in dev, I get a full error message.

Are you getting full error message only for malformed YAML, or for all other errors as well?

The only next steps I can think of are to try doing a clean install on your environment to see if there's something weird going on that's producing an edge case.

[yceruto]

@ikakarov the html error renderer won't work as service because there is a config error, so the container compilation process is broken. However, there is a fallback mechanism to catch that errors: see ErrorHandler::renderException() -> new HtmlErrorRenderer($this->debug).

You should see the exception page if $this->debug is true, and that will happen only if debug mode (Debug::enable()) is called on your front.

[blowski]

@yceruto Thanks.

I don't get why @ikakarov is not experiencing all sorts of weirdness if not in debug mode.

[xabbuh]

I am going to close here for now due to the lack of feedback. Please let us know when you have more information and we can consider to reopen.