[DomCrawler] Fixed image input case sensitive #10841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -667,7 +667,7 @@ public function selectLink($value) | |||
| public function selectButton($value) | |||
| { | |||
| $xpath = sprintf('//input[((@type="submit" or @type="button") and contains(concat(\' \', normalize-space(string(@value)), \' \'), %s)) ', static::xpathLiteral(' '.$value.' ')). | |||
| sprintf('or (@type="image" and contains(concat(\' \', normalize-space(string(@alt)), \' \'), %s)) or @id="%s" or @name="%s"] ', static::xpathLiteral(' '.$value.' '), $value, $value). | |||
| sprintf('or (lower-case(@type)="image" and contains(concat(\' \', normalize-space(string(@alt)), \' \'), %s)) or @id="%s" or @name="%s"] ', static::xpathLiteral(' '.$value.' '), $value, $value). | |||
There was a problem hiding this comment.
what about doing the same for type="submit" and type="button" above? Anywhere else where we can do the same?
There was a problem hiding this comment.
the type should indeed be case insensitive everywhere.
Adn this should be tested
|
@geoffrey-brier write some tests using an uppercase type attribute (i.e. exactly the case you faced) |
|
@stof I just wrote a test |
|
apparently, tests are broken (https://travis-ci.org/symfony/symfony/builds/24294084). |
|
@fabpot sounds like the |
|
Tests are broken but I don't think it comes from my modifications, could you confirm @fabpot ? |
|
Thank you @geoffrey-brier. |
fabpot
added a commit
that referenced
this pull request
May 12, 2014
…ier) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10841). Discussion ---------- [DomCrawler] Fixed image input case sensitive | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | I'm currently testing the payment workflow in a project. The problem is that when I reach the credit card type selection (CB, VISA ...) I cannot submit the desired one because its name is in uppercase (take a look at the screenshot).  Commits ------- ab1198f [DomCrawler] Fixed image input case sensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently testing the payment workflow in a project. The problem is that when I reach the credit card type selection (CB, VISA ...) I cannot submit the desired one because its name is in uppercase (take a look at the screenshot).